Skip to content

Initial UI for Suggestions Page #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jswan106 merged 4 commits into from
Mar 20, 2025
Merged

Initial UI for Suggestions Page #79

jswan106 merged 4 commits into from
Mar 20, 2025

Conversation

@jswan106
Copy link
Contributor

@jswan106 jswan106 commented Mar 14, 2025 •
edited
Loading

Adds the following:

jswan106 added 2 commits March 14, 2025 14:07
@jswan106
Adds #5 - Add first pass at Suggestions page UI for the vite-client
f220a94 
Adds #7 - Add SuggestionsContainer component
Adds #6 - Add SuggestionItem component
Adds useSocket custom react hook
Adds useSuggestionApi custom react hook
@jswan106
add socket and suggestion contexts and providers, remove commented ou…
c12cfcb 
…t debug code
@jswan106 jswan106 requested a review from illMadeCoder March 14, 2025 21:02
@jswan106 jswan106 added this to the Suggestion UI - MVP milestone Mar 14, 2025
@jswan106 jswan106 added the role: Frontend Developer Something that is UI specific label Mar 14, 2025
@jswan106
Copy link
Contributor Author

jswan106 commented Mar 19, 2025

Posting some feedback from @illMadeCoder for safe keeping and easy reference:

I'm noticing a couple things:

  1. I like the console logs, it'd be nice if we can maintain good metrics there including timestamps & latency. also they should be a config w/ the run dev build.
  2. if I stop talking for a minute I have to turn the transcript service off and on again.
  3. when I turn the transcript service off and on again I get this error.
useSpeechRecognition.js:65 Uncaught InvalidStateError: Failed to execute 'start' on 'SpeechRecognition': recognition has already started.
      at useSpeechRecognition.js:65:44

image

This was linked to issues Mar 19, 2025
Create UI for Suggestions Page Container #5
Closed
Create UI for Suggestion Item #6
Closed
Create UI for Suggestions Container #7
Closed
@jswan106 jswan106 merged commit 61695ba into main Mar 20, 2025
1 check passed
@jswan106 jswan106 deleted the feature/suggestions-page-ui branch March 20, 2025 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@illMadeCoder illMadeCoder Awaiting requested review from illMadeCoder

Assignees

No one assigned

Labels

role: Frontend Developer Something that is UI specific

Projects

None yet

Milestone

Suggestion UI - MVP

Development

Successfully merging this pull request may close these issues.

Create UI for Suggestions Container Create UI for Suggestion Item Create UI for Suggestions Page Container

2 participants

@jswan106